Skip to content

refactor: Build RBAC with recommended labels#806

Open
adwk67 wants to merge 11 commits into
mainfrom
feat/smooth-operator/build-rbac
Open

refactor: Build RBAC with recommended labels#806
adwk67 wants to merge 11 commits into
mainfrom
feat/smooth-operator/build-rbac

Conversation

@adwk67

@adwk67 adwk67 commented Jul 20, 2026 •
edited by siegfriedweber
Loading

Copy link
Copy Markdown
Member

Description

Part of: stackabletech/issues#869

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 mentioned this pull request Jul 20, 2026
Open
12 tasks
Base automatically changed from feat/smooth-operator/introduce-builder to main July 21, 2026 15:15
@adwk67 adwk67 self-assigned this Jul 21, 2026
@adwk67
adwk67 force-pushed the feat/smooth-operator/build-rbac branch from 3327a68 to 1c5b9cd Compare July 22, 2026 08:44
@siegfriedweber
siegfriedweber self-requested a review July 24, 2026 10:09
@adwk67

adwk67 commented Jul 24, 2026

Copy link
Copy Markdown
Member Author 
--- PASS: kuttl (713.35s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (200.51s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.4_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (169.36s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-external-unstable_openshift-false (182.27s)
        --- PASS: kuttl/harness/smoke_hadoop-3.5.0_zookeeper-3.9.5_zookeeper-latest-3.9.5_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false (713.34s)
PASS

siegfriedweber
siegfriedweber requested changes Jul 24, 2026
View reviewed changes
Comment thread rust/operator-binary/src/controller/build/mod.rs Outdated
Comment thread rust/operator-binary/src/controller/build/mod.rs
Comment thread rust/operator-binary/src/controller/build/mod.rs Outdated
Comment thread rust/operator-binary/src/controller/mod.rs
Comment on lines +108 to +109
let product_version = ProductVersion::from_str(&image.app_version_label_value)
.expect("the app version label value is a valid product version");

@siegfriedweber siegfriedweber Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of image.product_version if only image.app_version_label_value is used?

@adwk67 adwk67 Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.product_version is used when upgrading e.g. https://github.com/stackabletech/hdfs-operator/blob/feat/smooth-operator/build-rbac/rust/operator-binary/src/hdfs_controller.rs#L292.

@adwk67 adwk67 Jul 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the whole label there would cause problems.

Comment thread rust/operator-binary/src/controller/mod.rs Outdated
@siegfriedweber siegfriedweber mentioned this pull request Jul 24, 2026
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@adwk67 adwk67

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adwk67 @siegfriedweber